xanderbailey commented on code in PR #2701:
URL: https://github.com/apache/iceberg-rust/pull/2701#discussion_r3681933528
##########
crates/iceberg/src/writer/file_writer/parquet_writer.rs:
##########
@@ -114,13 +134,18 @@ impl FileWriterBuilder for ParquetWriterBuilder {
type R = ParquetWriter;
async fn build(&self, output_file: OutputFile) -> Result<Self::R> {
+ let key_metadata = self
Review Comment:
Which metadata file? `DatafileBuilder` gets the metadata here
https://github.com/apache/iceberg-rust/pull/2701/changes#diff-90353a086e76aaeaf0c244575969c53c8ab07a4d6453080a3c0898bee3872fddR490
Putting this in `build(&self, output_file: OutputFile,
Option<StandardKeyMetadata> key_metadata)` would mean the rolling writer
becomes "key metadata aware" and I don't think it needs to be.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
