aarushigupta132 commented on code in PR #2701:
URL: https://github.com/apache/iceberg-rust/pull/2701#discussion_r3682039874
##########
crates/integrations/datafusion/src/physical_plan/write.rs:
##########
@@ -601,4 +606,100 @@ mod tests {
Ok(())
}
+
+ #[tokio::test]
+ async fn test_iceberg_write_exec_encrypted() -> Result<()> {
Review Comment:
I believe a complete read-write test would require removing this
[check](https://github.com/apache/iceberg-rust/blob/c1d877da953e57cd4916b17dde63ad36ff128028/crates/iceberg/src/transaction/mod.rs#L184)
(as this would be a commit)
I would like to follow-up with more round trip tests, whenever we remove
this gate.
Would you recommend doing all the mentioned in this pr or should i just
remove this datafusion test here and add in a follow up pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
