stevenzwu commented on a change in pull request #1956:
URL: https://github.com/apache/iceberg/pull/1956#discussion_r551704679
##########
File path: flink/src/test/java/org/apache/iceberg/flink/FlinkTestBase.java
##########
@@ -76,7 +99,7 @@ protected TableEnvironment getTableEnv() {
TableResult tableResult = getTableEnv().executeSql(String.format(query,
args));
tableResult.getJobClient().ifPresent(c -> {
try {
-
c.getJobExecutionResult(Thread.currentThread().getContextClassLoader()).get();
+ c.getJobExecutionResult().get();
Review comment:
I was wondering the same question regarding
`c.getJobExecutionResult().get()`. Updated the PR per your suggestion.
##########
File path:
flink/src/test/java/org/apache/iceberg/flink/source/TestFlinkScanSql.java
##########
@@ -107,7 +121,14 @@ public void testResiduals() throws Exception {
}
private List<Row> executeSQL(String sql) {
- return Lists.newArrayList(tEnv.executeSql(sql).collect());
+ CloseableIterator<Row> iter = getTableEnv().executeSql(sql).collect();
Review comment:
updated
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
