pvary commented on code in PR #17610:
URL: https://github.com/apache/iceberg/pull/17610#discussion_r3767430313
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -114,6 +114,19 @@ protected boolean supportsBatchReads() {
return false;
}
+ protected boolean readOnly() {
+ return false;
+ }
+
+ protected Set<FileFormat> supportedFormats() {
Review Comment:
I don't really like this one.
Could we just re-define FILE_FORMATS, and FORMAT_AND_GENERATOR in
TestSparkVectorizedFormatModel?
```
private static final FileFormat[] FILE_FORMATS = {FileFormat.ORC,
FileFormat.PARQUET};
private static final List<Arguments> FORMAT_AND_GENERATOR
```
This relies on the fact, how junit works internally, but no change is
required in all of the tests.
I'm open for other ideas as well, this is just the first one occured to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
