joyhaldar commented on code in PR #17610:
URL: https://github.com/apache/iceberg/pull/17610#discussion_r3788541908
##########
data/src/test/java/org/apache/iceberg/data/BaseFormatModelTests.java:
##########
@@ -114,6 +114,19 @@ protected boolean supportsBatchReads() {
return false;
}
+ protected boolean readOnly() {
Review Comment:
I agree with you, would love your advice.
Two ways we could do it:
1. Keep the read tests and shared helpers in `BaseFormatModelTests`, move
the write tests into a `BaseReadWriteFormatModelTests` that extends it.
Existing tests move to the new class.
2. Insert a `BaseReadFormatModelTests` above the current
`BaseFormatModelTests` and put the read tests there. No existing subclass
changes its extends.
And `TestSparkVectorizedFormatModel` would only extend the read-only class.
Would you like to do it in a follow-up PR or this PR?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
