manuzhang commented on code in PR #17164: URL: https://github.com/apache/iceberg/pull/17164#discussion_r3772234297
########## core/src/main/java/org/apache/iceberg/BaseMetastoreTableOperations.java: ########## @@ -55,6 +55,7 @@ public abstract class BaseMetastoreTableOperations extends BaseMetastoreOperatio private String currentMetadataLocation = null; private boolean shouldRefresh = true; private int version = -1; + private volatile Long metadataFileSizeInBytes; Review Comment: the size is mutable per-ops-instance state, read later in `notifyListeners()`. If the same ops instance sees interleaved commits, the reported size can belong to a different metadata file than the reported snapshot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
