amirmor1 commented on code in PR #17164:
URL: https://github.com/apache/iceberg/pull/17164#discussion_r3774053609
##########
core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCommits.java:
##########
@@ -506,4 +510,31 @@ public void close() throws Exception {}
@Override
public void initialize(Map<String, String> properties) {}
}
+
+ @Test
+ public void testCommitReportContainsMetadataFileSizeInBytes() {
Review Comment:
Renamed to `commitReportContainsMetadataFileSizeInBytes`. Thanks.
##########
docs/docs/metrics-reporting.md:
##########
@@ -41,6 +41,7 @@ A
[`CommitReport`](https://github.com/apache/iceberg/blob/main/core/src/main/jav
* number of added/removed data/delete files
* number of added/removed equality/positional delete files
* number of added/removed equality/positional deletes
+* metadata file size in bytes for the committed table metadata file (optional,
may be null depending on catalog implementation)
Review Comment:
Agreed — reworded to "size in bytes of the table metadata file written by
the commit,
when available (some catalogs do not write metadata files directly)".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
