DerGut commented on code in PR #2920:
URL: https://github.com/apache/iceberg-rust/pull/2920#discussion_r3782117509
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -4120,4 +4363,115 @@ mod tests {
assert_eq!(err.message(), "Catalog uri is required");
}
}
+
+ #[tokio::test]
+ async fn test_create_session_catalog() {
+ let builder = RestSessionCatalogBuilder::default();
+
+ let result = builder
+ .load(
+ "test",
+ HashMap::from([
+ (
+ REST_CATALOG_PROP_URI.to_string(),
+ "http://localhost:8080".to_string(),
+ ),
+ ("a".to_string(), "b".to_string()),
+ ]),
+ )
+ .await;
+
+ assert!(result.is_ok());
+
+ let catalog = result.unwrap();
+
+ let catalog_config = catalog.user_config;
+ assert_eq!(catalog_config.name.as_deref(), Some("test"));
+ assert_eq!(catalog_config.uri, "http://localhost:8080";);
+ assert_eq!(catalog_config.warehouse, None);
+ // The default builder sets no client (only `with_client` does).
+ assert!(catalog_config.client.is_none());
+
+ // `uri` is consumed into its own field; other props are retained.
+ assert_eq!(catalog_config.props.get("a"), Some(&"b".to_string()));
+ assert!(!catalog_config.props.contains_key(REST_CATALOG_PROP_URI));
+ }
+
+ #[tokio::test]
+ async fn test_create_rest_catalog_with_session() {
+ let context = SessionContext::builder()
+ .session_id("test-id".to_string())
+ .build();
+
+ let result = RestCatalogBuilder::default()
+ .with_session_context(context)
+ .load(
+ "test",
+ HashMap::from([(
+ REST_CATALOG_PROP_URI.to_string(),
+ "http://localhost:8080".to_string(),
+ )]),
+ )
+ .await;
+
+ assert!(result.is_ok());
+
+ // The context passed to `with_session_context` is the one the catalog
is bound to.
+ let catalog = result.unwrap();
+ assert_eq!(catalog.session_context.session_id(), "test-id");
+ }
+
+ #[tokio::test]
+ async fn test_create_rest_catalog_default_session() {
+ let result = RestCatalogBuilder::default()
+ .load(
+ "test",
+ HashMap::from([(
+ REST_CATALOG_PROP_URI.to_string(),
+ "http://localhost:8080".to_string(),
+ )]),
+ )
+ .await;
+
+ assert!(result.is_ok());
+
+ // Without `with_session`, the catalog falls back to
`SessionContext::empty()`,
Review Comment:
Updated in
https://github.com/apache/iceberg-rust/pull/2920/commits/908c82058a8459ba5efcc9ebc23da8c205f9eb34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
