DerGut commented on code in PR #2920:
URL: https://github.com/apache/iceberg-rust/pull/2920#discussion_r3782179773
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -890,13 +1012,17 @@ impl Catalog for RestCatalog {
}
}
- async fn namespace_exists(&self, ns: &NamespaceIdent) -> Result<bool> {
+ async fn namespace_exists(
+ &self,
+ context: &SessionContext,
+ ns: &NamespaceIdent,
+ ) -> Result<bool> {
// Prefer a cheap HEAD when the server advertises it; otherwise fall
back
// to loading the namespace (GET) and treating a missing namespace as
// `false`, so this still works against servers that don't advertise
the
// HEAD route.
if !self.supports_endpoint(&V1_NAMESPACE_EXISTS).await? {
Review Comment:
Updated in
https://github.com/apache/iceberg-rust/pull/2920/commits/908c82058a8459ba5efcc9ebc23da8c205f9eb34
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
