cccs-jc commented on a change in pull request #1979:
URL: https://github.com/apache/iceberg/pull/1979#discussion_r553469714
##########
File path: core/src/main/java/org/apache/iceberg/hadoop/HadoopCatalog.java
##########
@@ -158,6 +167,44 @@ public String name() {
return catalogName;
}
+ private boolean shouldSuppressIOException(IOException ioException) {
+ String name = ioException.getClass().getName();
+ return suppressIOException &&
name.startsWith("org.apache.hadoop.fs.azurebfs");
Review comment:
I have fixed the code review suggestions.
I'm detecting the azure blob permission exception using the message (that's
all I have available). In that message there is an AzureServiceErrorCode of
value "AuthorizationPermissionMismatch" which I use to detect a permission
issue.
I agree this is much better error handling since it will let other errors be
reported.
I'm thinking the flag should thus be "suppress permission errors". What do
you think?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
