lukeFalsina commented on code in PR #3724:
URL: https://github.com/apache/iceberg-python/pull/3724#discussion_r3795689057
##########
mkdocs/docs/configuration.md:
##########
@@ -386,6 +386,10 @@ catalog:
| snapshot-loading-mode | refs | The snapshots to
return in the body of the metadata. Setting the value to `all` would return the
full set of snapshots currently valid for the table. Setting the value to
`refs` would load all snapshots referenced by branches or tags. |
| `header.X-Iceberg-Access-Delegation` | `vended-credentials` | Signal to the
server that the client supports delegated access via a comma-separated list of
access mechanisms. The server may choose to supply access via any or none of
the requested mechanisms. When using `vended-credentials`, the server provides
temporary credentials to the client. When using `remote-signing`, the server
signs requests on behalf of the client. (default: `vended-credentials`) |
| view-endpoints-supported | false | For backwards
compatibility with older REST servers. Set to `true` if the server supports
view endpoints but doesn't send the `endpoints` field in the ConfigResponse. |
+| scan-planning-mode | client | When set to `server`, and the catalog
advertises the plan-table-scan endpoint, `table.scan()` uses REST server-side
scan planning. Async plans (`status=submitted`) are polled via `GET
.../plan/{plan-id}` until completion. |
Review Comment:
Yes — for my earlier testing I was setting `scan-planning-mode=server` as a
catalog-wide client property.
Your proposal makes more sense, so I've updated the PR to honor
`scan-planning-mode` from `LoadTableResponse.config`, with the table override
taking precedence over the catalog-level setting (matching Java).
I also re-tested from client code with the catalog-wide property unset,
relying only on the `loadTable` configs. That is much simpler from a user
perspective, and it worked well when reading a mix of protected and unprotected
tables from the same catalog in one session — I verified the client followed
the plan choice returned by the server for both table types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
