dramaticlly opened a new pull request, #17763: URL: https://github.com/apache/iceberg/pull/17763
2 bug make it right: 1. FileCleanupStrategy#readManifests projects the manifest list without the content field (517) and GenericManifestFile defaults content to DATA and only assigns it when the field is projected, so every manifest handled by ReachableFileCleanup and IncrementalFileCleanup reports ManifestContent.DATA, including delete manifests. 2. ManifestFiles.readPath open reads data manifest and ManifestReader does not derive its schema from FileType. Clean up of delete manifest as part of snapshot expiration is already covered today in https://github.com/apache/iceberg/blob/7f879b11366e17a676a03f15247a821751415529/core/src/test/java/org/apache/iceberg/TestRemoveSnapshots.java#L1040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
