dramaticlly commented on code in PR #17763:
URL: https://github.com/apache/iceberg/pull/17763#discussion_r3834104522
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -113,7 +113,7 @@ public static CacheMetricsReport contentCacheStats(FileIO
io) {
public static CloseableIterable<String> readPaths(
ManifestFile manifest, FileIO io, Map<Integer, PartitionSpec> specsById)
{
return CloseableIterable.transform(
- read(manifest, io,
specsById).select(ImmutableList.of("file_path")).liveEntries(),
+ open(manifest, io,
specsById).select(ImmutableList.of("file_path")).liveEntries(),
Review Comment:
read() only handles data manifests while open handle both data and delete
manifests
##########
core/src/main/java/org/apache/iceberg/ManifestFiles.java:
##########
@@ -113,7 +113,7 @@ public static CacheMetricsReport contentCacheStats(FileIO
io) {
public static CloseableIterable<String> readPaths(
ManifestFile manifest, FileIO io, Map<Integer, PartitionSpec> specsById)
{
return CloseableIterable.transform(
- read(manifest, io,
specsById).select(ImmutableList.of("file_path")).liveEntries(),
+ open(manifest, io,
specsById).select(ImmutableList.of("file_path")).liveEntries(),
Review Comment:
read() only handles data manifests while open() handle both data and delete
manifests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
