JosephLenton commented on code in PR #2937:
URL: https://github.com/apache/iceberg-rust/pull/2937#discussion_r3841783359
##########
crates/iceberg/src/transaction/action.rs:
##########
@@ -34,7 +34,7 @@ pub(crate) type BoxedTransactionAction = Arc<dyn
TransactionAction>;
/// Each action is responsible for generating the updates and requirements
needed
/// to modify the table metadata.
#[async_trait]
-pub(crate) trait TransactionAction: AsAny + Sync + Send {
+pub trait TransactionAction: AsAny + Sync + Send {
Review Comment:
That is reverted and is no longer exported.
However the trait is still exposed in one place on the docs via the broad
static implementation. This is present on the main docs
[here](https://docs.rs/iceberg/latest/iceberg/transaction/trait.ApplyTransactionAction.html#implementors).
<img width="1040" height="166" alt="image"
src="https://github.com/user-attachments/assets/0c9ec91c-c7e7-4563-ae7e-a20bf23afac5";
/>
To stop this MR growing further I'd suggest fixing this in a later issue. As
a quick hack I could add a `#[doc(hidden)]`, but I think it obfuscates how
`ApplyTransactionAction` connects to other types. So I'm inclined to just leave
it and I can help tidy this up in a later MR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
