JosephLenton commented on code in PR #2937:
URL: https://github.com/apache/iceberg-rust/pull/2937#discussion_r3841783359
##########
crates/iceberg/src/transaction/action.rs:
##########
@@ -34,7 +34,7 @@ pub(crate) type BoxedTransactionAction = Arc<dyn
TransactionAction>;
/// Each action is responsible for generating the updates and requirements
needed
/// to modify the table metadata.
#[async_trait]
-pub(crate) trait TransactionAction: AsAny + Sync + Send {
+pub trait TransactionAction: AsAny + Sync + Send {
Review Comment:
That is reverted and is still hidden.
However the trait is still exposed in the docs via the broad static
implementation.
<img width="1040" height="166" alt="image"
src="https://github.com/user-attachments/assets/0c9ec91c-c7e7-4563-ae7e-a20bf23afac5";
/>
To stop this MR growing further, I'd suggest we leave fixing this in a later
issue. This is because the only options I can think of are a `#[doc(hidden)]`
or refactoring a lot of code. I don't like the doc hidden as it obfuscates how
`ApplyTransactionAction` is applied to other types. I can go the refactoring
route, but it would be better in a followup MR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
