kevinjqliu commented on PR #3842: URL: https://github.com/apache/iceberg-python/pull/3842#issuecomment-5544680210
Thanks for iterating on this @hedger9487! I took a pass at simplifying the read-side fallback and pushed a reference branch: https://github.com/apache/iceberg-python/compare/main...kevinjqliu:iceberg-python:claude/schema-long-int-avro-fallback-4ec219 The main differences from this PR: - Match on the exact field id path `[2, 135, 136]` (`data_file.equality_ids.element`) instead of `136 in self.context` plus the `read_types` name check. This keeps the exception scoped without the resolver needing to know about `DataFile`. - Return the existing `IntegerReader` for the legacy case, since ints and longs share the same Avro encoding. No new reader class needed. - One test that writes a manifest with the legacy `list<long>` schema and reads it back, replacing the flag-based tests. Would you mind adopting that shape here? Happy to take it over if you'd prefer, just let me know. Once this lands we can follow up with the `rewrite_manifests` maintenance action from the plan in #3840. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
