hedger9487 commented on PR #3842: URL: https://github.com/apache/iceberg-python/pull/3842#issuecomment-5550478484
Thanks @kevinjqliu! That’s so much cleaner and more scoped. I've adopted your reference branch shape directly: 1. Matched on the exact field ID path `[2, 135, 136]`, decoupling the resolver from `DataFile`. 2. Directly return `IntegerReader()` for the legacy fallback. 3. Replaced earlier tests with the monkeypatched end-to-end legacy manifest round-trip test, and reverted the unrelated cache/fixture diffs. All pre-commit hooks, linters, and unit tests are green locally. I've rebased onto the latest `main`, credited you as co-author, and force-pushed the updated branch! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
