paleolimbot commented on code in PR #2933: URL: https://github.com/apache/iceberg-rust/pull/2933#discussion_r3937611436
########## crates/iceberg/src/spec/datatypes.rs: ########## @@ -43,6 +43,8 @@ pub const MAP_VALUE_FIELD_NAME: &str = "value"; pub(crate) const MAX_DECIMAL_BYTES: u32 = 24; pub(crate) const MAX_DECIMAL_PRECISION: u32 = 38; +const DEFAULT_GEOSPATIAL_CRS: &str = "OGC:CRS84"; +const EQUIVALENT_DEFAULT_GEOSPATIAL_CRS: &str = "EPSG:4326"; Review Comment: It's a consequence of https://github.com/apache/parquet-format/blob/master/Geospatial.md#coordinate-axis-order : the second form ESPG:4326 is common and carries the same meaning as OGC:CRS84. Normalizing them on convert reduces the chance that perfectly valid data gets rejected because an unequal schema. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
