dannycjones commented on code in PR #2933: URL: https://github.com/apache/iceberg-rust/pull/2933#discussion_r3970203211
########## crates/iceberg/src/spec/datatypes.rs: ########## @@ -43,6 +43,8 @@ pub const MAP_VALUE_FIELD_NAME: &str = "value"; pub(crate) const MAX_DECIMAL_BYTES: u32 = 24; pub(crate) const MAX_DECIMAL_PRECISION: u32 = 38; +const DEFAULT_GEOSPATIAL_CRS: &str = "OGC:CRS84"; +const EQUIVALENT_DEFAULT_GEOSPATIAL_CRS: &str = "EPSG:4326"; Review Comment: Thanks for elaborating on this, that explanation helps. I suppose this remains a problem on iceberg-java. I don't think there's a precedent of this type of behavior in Iceberg before geospatial types, hence my doubt here. I appreciate you articulating the end-user problem well, but I think really we need a mailing list thread to make a decision on this behavior. I'm planning to write up a plan of all the components that need to go in to consider iceberg-rust as "fully supporting" geospatial types (and hopefully it represents the impl path for new types more broadly), so we can coordinate committer reviews. I'll mention this as one decision point, but it would be great to start that conversation earlier. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
