rdblue commented on code in PR #17932:
URL: https://github.com/apache/iceberg/pull/17932#discussion_r3938171538
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileAdapters.java:
##########
@@ -91,6 +94,37 @@ class TestTrackedFileAdapters {
CONTENT_STATS.setStats(3, GEOM_STATS);
}
+ private static final Tracking MANIFEST_TRACKING =
+ new TrackingStruct(
+ EntryStatus.ADDED,
+ SNAPSHOT_ID,
+ // data and file sequence numbers must be equal
+ DATA_SEQUENCE_NUMBER,
+ DATA_SEQUENCE_NUMBER,
+ null, // dvSnapshotId
+ FIRST_ROW_ID,
+ null, // deletedPositions
+ null); // replacedPositions
+
+ private static final byte[] MANIFEST_DV = new byte[] {1, 2, 3};
+
+ private static final ByteBuffer MANIFEST_KEY_METADATA = ByteBuffer.wrap(new
byte[] {7, 8, 9});
+
+ private static final ManifestInfo MANIFEST_INFO =
+ ManifestInfoStruct.builder()
+ .addedFilesCount(3)
+ .existingFilesCount(5)
+ .deletedFilesCount(2)
+ .replacedFilesCount(0)
Review Comment:
@stevenzwu added these methods to `ManifestFile` in
https://github.com/apache/iceberg/pull/16936/changes. Maybe we should add those
here first, since this is a simpler interface?
If we add them, then I think we should test non-zero values. I think that
these should default to 0 since that is the case for pre-v4 manifest files.
(See my comment:
https://github.com/apache/iceberg/pull/16936/changes#r3929689004)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
