rdblue commented on code in PR #17932:
URL: https://github.com/apache/iceberg/pull/17932#discussion_r3938158203
##########
core/src/test/java/org/apache/iceberg/TestTrackedFileAdapters.java:
##########
@@ -91,6 +94,37 @@ class TestTrackedFileAdapters {
CONTENT_STATS.setStats(3, GEOM_STATS);
}
+ private static final Tracking MANIFEST_TRACKING =
+ new TrackingStruct(
+ EntryStatus.ADDED,
+ SNAPSHOT_ID,
+ // data and file sequence numbers must be equal
Review Comment:
Minor: I don't think this is always true. They can be equal. But I think in
the case when you add a new column file, the data sequence number gets updated,
but the file sequence number would not.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
