Copilot commented on code in PR #873: URL: https://github.com/apache/iceberg-cpp/pull/873#discussion_r3946303635
########## src/iceberg/type_fwd.h: ########## @@ -24,6 +24,8 @@ /// you can include this instead of the "full" headers to help reduce compile /// times. +#include <memory> + Review Comment: `FileScanTaskIterator` (a `std::unique_ptr<Iterator<...>>`) is defined in this forward-declaration header, but `Iterator` is only forward-declared here. Any TU that includes only `type_fwd.h` and lets a `FileScanTaskIterator` go out of scope will require `Iterator` to be a complete type (default deleter), which can cause compile failures. Consider ensuring `Iterator` is complete when including this header (or moving the alias out of `type_fwd.h`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
