Copilot commented on code in PR #873: URL: https://github.com/apache/iceberg-cpp/pull/873#discussion_r3981505042
########## src/iceberg/manifest/manifest_reader.h: ########## @@ -33,22 +33,41 @@ #include "iceberg/metrics/counter.h" #include "iceberg/result.h" #include "iceberg/type_fwd.h" +#include "iceberg/util/stream.h" Review Comment: `ManifestEntryStream` aliases `Stream<ManifestEntry>`, but `ManifestEntry` is only forward-declared via `type_fwd.h`. `Stream<T>`'s interface uses `std::optional<T>`/`std::vector<T>`, which requires `T` to be a complete type at the point of instantiation, so this header will fail to compile unless callers happen to include `manifest_entry.h` first. Include the `ManifestEntry` definition here (or change the stream to use an indirection type). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
