Fokko commented on code in PR #3900:
URL: https://github.com/apache/iceberg-python/pull/3900#discussion_r3958352826
##########
pyiceberg/table/update/snapshot.py:
##########
@@ -1192,6 +1202,8 @@ def rollback_to_snapshot(self, snapshot_id: int) ->
ManageSnapshots:
Raises:
ValueError: If the snapshot does not exist or is not an ancestor
of the current table state.
"""
+ self._commit_if_ref_updates_exist()
Review Comment:
This is outside of the scope of this PR, but I was a bit surprised by this.
Based on the method name, I expected it to perform an actual commit, but after
reading the code, it turns out it stages the commit within the transaction.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
