Ferdinanddb commented on PR #3900: URL: https://github.com/apache/iceberg-python/pull/3900#issuecomment-5586670461
Thanks a lot for the review @Fokko ! Before I push anything: @[JeroenSchmidt](https://github.com/JeroenSchmidt) pushed the pending changes to #3649 this morning, so the original PR is alive again. We discussed it and agreed to consolidate on his, since it came first. So this one can be closed once #3649 lands. I created this current PR because the original one was not touched since a month. One remark, since the two implementations diverged: your comments here are on code that only exists in this PR. #3649 reads the pending refs through a hand-rolled `_effective_refs()` that rebuilds `SnapshotRef` objects from the staged `SetSnapshotRefUpdate`s, rather than going through `update_table_metadata`, and it does not touch `_commit_if_ref_updates_exist`. Thank you in advance, and sorry for this convoluted situation! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
