nastra commented on code in PR #17912:
URL: https://github.com/apache/iceberg/pull/17912#discussion_r3965288379
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -461,7 +464,14 @@ private void refreshStorageCredentials() {
return;
}
- try (VendedCredentialsProvider provider =
VendedCredentialsProvider.create(properties)) {
+ Map<String, String> refreshProperties = Maps.newHashMap(properties);
Review Comment:
we are doing this already in
https://github.com/apache/iceberg/blob/48da548979099d0c33c8f39062f728175f786538/aws/src/main/java/org/apache/iceberg/aws/AwsClientProperties.java#L120-L122
Why do we need to do it here again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
