nastra commented on code in PR #17912:
URL: https://github.com/apache/iceberg/pull/17912#discussion_r3965421768
##########
aws/src/main/java/org/apache/iceberg/aws/s3/S3FileIO.java:
##########
@@ -461,7 +464,14 @@ private void refreshStorageCredentials() {
return;
}
- try (VendedCredentialsProvider provider =
VendedCredentialsProvider.create(properties)) {
+ Map<String, String> refreshProperties = Maps.newHashMap(properties);
+ refreshProperties.putIfAbsent(
+ VendedCredentialsProvider.URI,
+ RESTUtil.resolveEndpoint(
Review Comment:
I guess we would have the same issue with GCSFileIO when its
`refreshStorageCredentials()` is being called, right? Maybe we should fix both
places then
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
