Guosmilesmile commented on PR #17280: URL: https://github.com/apache/iceberg/pull/17280#issuecomment-5644842091
@talatuyarer Thanks a lot for the suggestions! 1. **RocksDB dependency**: I've changed it from `bundle` to `compileOnly`, so the dependency now comes directly from the Flink cluster. 2. **FullCachingLookupProvider**: Good point ,I'll look into refactoring it to see how it can be combined with the multi-type cache. 3. **FLIP-426**: I've read through it. Since it requires shuffling the data and depends on configuring buckets, it could introduce significant overhead at large scale, and may also create hot spots that lead to single-node bottlenecks. Therefore, the RocksDB-based lookup still has its place. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
