Guosmilesmile commented on code in PR #17280:
URL: https://github.com/apache/iceberg/pull/17280#discussion_r3995666583
##########
gradle/libs.versions.toml:
##########
@@ -181,6 +182,7 @@ parquet-avro = { module =
"org.apache.parquet:parquet-avro", version.ref = "parq
parquet-column = { module = "org.apache.parquet:parquet-column", version.ref =
"parquet" }
parquet-hadoop = { module = "org.apache.parquet:parquet-hadoop", version.ref =
"parquet" }
roaringbitmap = { module = "org.roaringbitmap:RoaringBitmap", version.ref =
"roaringbitmap" }
+rocksdbjni = { module = "org.rocksdb:rocksdbjni", version.ref = "rocksdbjni" }
Review Comment:
Changed as you suggested. We don't bundle RocksDB anymore. The connector
uses compileOnly, and tests use testImplementation, so org.rocksdb comes from
the Flink cluster.
Bundling it usually wouldn't help because Flink uses its own RocksDB version
first. In some cases, like SQL Client, it could even cause a version conflict.
So, not bundling RocksDB is the right choice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
