szehon-ho commented on code in PR #18057: URL: https://github.com/apache/iceberg/pull/18057#discussion_r4010276495
########## format/udf-spec.md: ########## @@ -107,7 +107,11 @@ Notes: Types are based on the [Iceberg Type](https://iceberg.apache.org/spec/#schemas-and-data-types). Primitive and semi-structured type strings are encoded based on [Iceberg Type JSON Representation][iceberg-type-json] -(e.g., `int`, `string`, `timestamp`, `decimal(9,2)`, `variant`). Type strings must contain no spaces or quote characters. +(e.g., `int`, `string`, `timestamp`, `decimal(9, 2)`, `variant`). Type strings must contain no quote characters. + +Writers must use Iceberg's canonical serialized form. Readers should accept optional whitespace around parameters and +separators. Implementations must compare parsed types, not raw type strings. Canonicalization may normalize syntactic Review Comment: This requirement looks right. As a follow-up, #15994 still compares canonicalized type strings. Please ensure it compares parsed Iceberg types so equivalent forms such as and are treated as equal. ########## format/udf-spec.md: ########## @@ -107,7 +107,11 @@ Notes: Types are based on the [Iceberg Type](https://iceberg.apache.org/spec/#schemas-and-data-types). Primitive and semi-structured type strings are encoded based on [Iceberg Type JSON Representation][iceberg-type-json] -(e.g., `int`, `string`, `timestamp`, `decimal(9,2)`, `variant`). Type strings must contain no spaces or quote characters. +(e.g., `int`, `string`, `timestamp`, `decimal(9, 2)`, `variant`). Type strings must contain no quote characters. + +Writers must use Iceberg's canonical serialized form. Readers should accept optional whitespace around parameters and +separators. Implementations must compare parsed types, not raw type strings. Canonicalization may normalize syntactic Review Comment: This requirement looks right. As a follow-up, #15994 still compares canonicalized type strings. Please ensure it compares parsed Iceberg types so equivalent forms such as `geometry` and `geometry(ogc:crs84)` are treated as equal. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
