rdblue commented on a change in pull request #2325:
URL: https://github.com/apache/iceberg/pull/2325#discussion_r594635018
##########
File path:
hive-metastore/src/main/java/org/apache/iceberg/hive/HiveTableOperations.java
##########
@@ -98,15 +97,16 @@
private final long lockCheckMinWaitTime;
private final long lockCheckMaxWaitTime;
private final FileIO fileIO;
+ private final HiveCatalog catalog;
- protected HiveTableOperations(Configuration conf, HiveClientPool
metaClients, FileIO fileIO,
- String catalogName, String database, String
table) {
+ protected HiveTableOperations(Configuration conf, FileIO fileIO, HiveCatalog
catalog,
Review comment:
Agreed. I think that expiring connections in the pool rather than the
pool itself would solve this problem and would be a better solution for
managing connections in the long term.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
