marton-bod commented on a change in pull request #2325:
URL: https://github.com/apache/iceberg/pull/2325#discussion_r593303519
##########
File path: hive-metastore/src/main/java/org/apache/iceberg/hive/HiveCatalog.java
##########
@@ -50,25 +55,37 @@
import org.apache.iceberg.exceptions.NoSuchTableException;
import org.apache.iceberg.hadoop.HadoopFileIO;
import org.apache.iceberg.io.FileIO;
-import org.apache.iceberg.relocated.com.google.common.base.Joiner;
+import
org.apache.iceberg.relocated.com.google.common.annotations.VisibleForTesting;
import org.apache.iceberg.relocated.com.google.common.base.MoreObjects;
import org.apache.iceberg.relocated.com.google.common.base.Preconditions;
import org.apache.iceberg.relocated.com.google.common.collect.ImmutableList;
import org.apache.iceberg.relocated.com.google.common.collect.Maps;
+import
org.apache.iceberg.relocated.com.google.common.util.concurrent.ThreadFactoryBuilder;
+import org.apache.iceberg.util.Pair;
import org.apache.iceberg.util.PropertyUtil;
import org.apache.thrift.TException;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-public class HiveCatalog extends BaseMetastoreCatalog implements Closeable,
SupportsNamespaces, Configurable {
+public class HiveCatalog extends BaseMetastoreCatalog implements
SupportsNamespaces, Configurable {
private static final Logger LOG = LoggerFactory.getLogger(HiveCatalog.class);
+ public static final String CACHE_CLEANER_INTERVAL =
"iceberg.hive.client-pool-cache-cleaner-interval";
+ private static final long CACHE_CLEANER_INTERVAL_DEFAULT =
TimeUnit.SECONDS.toMillis(30);
+ public static final String CACHE_EVICTION_INTERVAL =
"iceberg.hive.client-pool-cache-eviction-interval";
+ private static final long CACHE_EVICTION_INTERVAL_DEFAULT =
TimeUnit.MINUTES.toMillis(5);
Review comment:
Quick question: is there a rationale behind the 5 minutes cache eviction
as a default? Does it typically become stale somehow after a few minutes that
we need to replace it? Just wondering, given that the pool recreation has a cost
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
