TGooch44 commented on a change in pull request #2655:
URL: https://github.com/apache/iceberg/pull/2655#discussion_r643022271



##########
File path: python/iceberg/api/expressions/literals.py
##########
@@ -243,6 +260,9 @@ def to(self, type_var):
                                       .quantize(Decimal("." + "".join(["0" for 
i in range(1, type_var.scale)]) + "1"),
                                                 rounding=ROUND_HALF_UP))
 
+    def type_id(self):

Review comment:
       That makes the most sense to me.  Since it will cause a number of 
changes in unrelated files, what do you think about opening an issue on it, and 
handling in a separate PR?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to