TGooch44 commented on a change in pull request #2655:
URL: https://github.com/apache/iceberg/pull/2655#discussion_r643040742
##########
File path: python/iceberg/api/expressions/literals.py
##########
@@ -243,6 +260,9 @@ def to(self, type_var):
.quantize(Decimal("." + "".join(["0" for
i in range(1, type_var.scale)]) + "1"),
rounding=ROUND_HALF_UP))
+ def type_id(self):
Review comment:
I think I misunderstood what you were proposing. Let me walk that back,
haha. You're just saying in the child-class pass into the super constructor
the type_id of the child and then just implement a single type_id attr in the
BaseLiteral. I agree that does seem better to me and is appropriate to handle
within this PR.
I'm also going to go ahead and finish my coffee before reading any more PRs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
