pvary commented on a change in pull request #2658:
URL: https://github.com/apache/iceberg/pull/2658#discussion_r648124495
##########
File path: core/src/main/java/org/apache/iceberg/DataFilesTable.java
##########
@@ -122,7 +122,7 @@ public long targetSplitSize() {
@Override
public CloseableIterable<StructLike> rows() {
return CloseableIterable.transform(
- ManifestFiles.read(manifest, io).project(schema),
+ ManifestFiles.read(manifest, io, null, null).project(schema),
Review comment:
Could we keep the original signatures as well, so we do not have to
rewrite the method calls everywhere and add `null, null`? I think this could
greatly reduce the changes needed in this patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
