anuragmantri commented on a change in pull request #2658:
URL: https://github.com/apache/iceberg/pull/2658#discussion_r655886250



##########
File path: core/src/main/java/org/apache/iceberg/DataTableScan.java
##########
@@ -71,7 +71,8 @@ protected TableScan newRefinedScan(TableOperations ops, Table 
table, Schema sche
   public CloseableIterable<FileScanTask> planFiles(TableOperations ops, 
Snapshot snapshot,
                                                    Expression rowFilter, 
boolean ignoreResiduals,
                                                    boolean caseSensitive, 
boolean colStats) {
-    ManifestGroup manifestGroup = new ManifestGroup(ops.io(), 
snapshot.dataManifests(), snapshot.deleteManifests())
+    ManifestGroup manifestGroup = new ManifestGroup(ops.io(), 
snapshot.dataManifests(), snapshot.deleteManifests(),
+        ops.current().location(), ops.current().properties())

Review comment:
       Instead of  pushing `properties` around, I introduced a flag 
`shouldUseRelativePaths`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to