nastra commented on a change in pull request #2739:
URL: https://github.com/apache/iceberg/pull/2739#discussion_r659604909
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -169,6 +172,9 @@ public VectorHolder read(VectorHolder reuse, int
numValsToRead) {
case TIMESTAMP_MILLIS:
vectorizedColumnIterator.nextBatchTimestampMillis(vec, typeWidth,
nullabilityHolder);
break;
+ case UUID:
Review comment:
`TIME_MICROS` and `TIMESTAMP_MICROS` are evaluated as `LONG`:
https://github.com/nastra/iceberg/blob/21af7bcd73f450e997d1af085634567a734a16b9/arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java#L240-L255
so both are basically handled in the `LONG` part of that switch statement.
Only `UUID` needs to be handled differently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
