nastra commented on a change in pull request #2739:
URL: https://github.com/apache/iceberg/pull/2739#discussion_r659783420
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -240,6 +247,12 @@ private void allocateFieldVector(boolean
dictionaryEncodedVector) {
this.readType = ReadType.LONG;
this.typeWidth = (int) BigIntVector.TYPE_WIDTH;
break;
+ case TIME_MICROS:
Review comment:
I will look into supporting `TIME_MILLIS` as a follow-up tomorrow
##########
File path:
arrow/src/main/java/org/apache/iceberg/arrow/vectorized/VectorizedArrowReader.java
##########
@@ -240,6 +247,12 @@ private void allocateFieldVector(boolean
dictionaryEncodedVector) {
this.readType = ReadType.LONG;
this.typeWidth = (int) BigIntVector.TYPE_WIDTH;
break;
+ case TIME_MICROS:
Review comment:
after some investigation, supporting `TIME_MILLIS` might be a bit more
involved. I opened https://github.com/apache/iceberg/issues/2755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
