kbendick commented on a change in pull request #2965:
URL: https://github.com/apache/iceberg/pull/2965#discussion_r688356457



##########
File path: core/src/main/java/org/apache/iceberg/TableProperties.java
##########
@@ -142,6 +142,12 @@ private TableProperties() {
   // This only applies to files written after this property is set. Files 
previously written aren't
   // relocated to reflect this parameter.
   // If not set, defaults to a "data" folder underneath the root path of the 
table.
+  public static final String WRITE_FOLDER_STORAGE_LOCATION = 
"write.folder-storage.path";
+
+  /**
+   * @deprecated will be removed in 0.14.0, use {@link 
#WRITE_FOLDER_STORAGE_LOCATION} instead
+   */
+  @Deprecated

Review comment:
       +1 to the deprecation.
   
   When the deprecation comes around, we should consider providing an action to 
migrate tables off of deprecated properties. In general, I think that would 
allow us to make smarter decisions about table property names as new needs 
surface. Something similar to the v2 table migration action. But that’s a long 
ways off.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to