jackye1995 commented on pull request #2965: URL: https://github.com/apache/iceberg/pull/2965#issuecomment-902197637
@flyrain great point around this, I am fully for a consolidation, this PR is really to prepare for that. My thought is the following: 1. in #2845 I implemented the fallback strategy 2. in this PR, we first consolidate the variable name to be consistent 3. in a subsequent PR, we can deprecate `write.object-storage.path` and only have 1 overwrite config. For 3, my thinking is to avoid the need to introduce yet another config key, although I understand the name `write.folder-storage.path` isn't really ideal. Ideally we can have `write.data.path` which parallels `write.metadata.path`, but I really don't want to introduce yet another variable. What's your thoughts on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
