aokolnychyi commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r690838931
##########
File path: baseline.gradle
##########
@@ -47,7 +47,8 @@ subprojects {
// So we apply Spotless manually to get a similar effect to baseline-format,
but change the
// import order.
- pluginManager.withPlugin('com.diffplug.gradle.spotless') {
+
Review comment:
nit: extra line?
##########
File path: baseline.gradle
##########
@@ -36,7 +36,7 @@ subprojects {
apply plugin: 'com.palantir.baseline-checkstyle'
apply plugin: 'com.palantir.baseline-error-prone'
}
- apply plugin: 'com.palantir.baseline-scalastyle'
+ apply plugin: 'com.github.alisiikh.scalastyle'
Review comment:
How widely is this plugin used? What's the license? I did not find that
in their GitHub.
##########
File path:
hive3/src/main/java/org/apache/iceberg/mr/hive/vector/CompatibilityHiveVectorUtils.java
##########
@@ -59,7 +59,7 @@ private CompatibilityHiveVectorUtils() {
* Returns serialized mapwork instance from a job conf - ported from Hive
source code LlapHiveUtils#findMapWork
*
* @param job JobConf instance
- * @return
+ * @return A serialized {@link MapWork} based on the given job conf
Review comment:
nit: We usually start with a lower case after `@return`.
##########
File path: baseline.gradle
##########
@@ -82,4 +83,15 @@ subprojects {
)
}
}
-}
+
+ pluginManager.withPlugin('com.github.alisiikh.scalastyle') {
+ scalastyle {
+ config = file("${rootDir}/project/scalastyle_config.xml")
+ inputEncoding = 'UTF-8'
+ outputEncoding = 'UTF-8'
+ failOnWarning = false
+ verbose = false
+ quiet = false
+ }
+ }
+}
Review comment:
nit: missing an empty line at the end of the file?
##########
File path: mr/src/test/java/org/apache/iceberg/mr/hive/TestTables.java
##########
@@ -115,7 +115,7 @@ public String catalogName() {
/**
* The table properties string needed for the CREATE TABLE ... commands,
* like "TBLPROPERTIES('iceberg.catalog'='mycatalog')
- * @return
+ * @return The tables properties string, such as
"TBLPROPERTIES('iceberg.catalog'='mycatalog')
Review comment:
I think quotes are not aligned too
##########
File path: mr/src/test/java/org/apache/iceberg/mr/hive/TestTables.java
##########
@@ -115,7 +115,7 @@ public String catalogName() {
/**
* The table properties string needed for the CREATE TABLE ... commands,
* like "TBLPROPERTIES('iceberg.catalog'='mycatalog')
- * @return
+ * @return The tables properties string, such as
"TBLPROPERTIES('iceberg.catalog'='mycatalog')
Review comment:
nit: same here
##########
File path: core/src/test/java/org/apache/iceberg/TestTableMetadata.java
##########
@@ -90,11 +90,11 @@ public void testJsonConversion() throws Exception {
long previousSnapshotId = System.currentTimeMillis() - new
Random(1234).nextInt(3600);
Snapshot previousSnapshot = new BaseSnapshot(
ops.io(), previousSnapshotId, null, previousSnapshotId, null, null,
null, ImmutableList.of(
- new GenericManifestFile(localInput("file:/tmp/manfiest.1.avro"),
SPEC_5.specId())));
+ new GenericManifestFile(localInput("file:/tmp/manfiest.1.avro"),
SPEC_5.specId())));
Review comment:
Are these required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
