flyrain commented on a change in pull request #2826:
URL: https://github.com/apache/iceberg/pull/2826#discussion_r691463863
##########
File path: gradlew
##########
@@ -28,7 +44,7 @@ APP_NAME="Gradle"
APP_BASE_NAME=`basename "$0"`
# Add default JVM options here. You can also use JAVA_OPTS and GRADLE_OPTS to
pass JVM options to this script.
-DEFAULT_JVM_OPTS=""
+DEFAULT_JVM_OPTS='"-Xmx64m" "-Xms64m"'
Review comment:
Is it necessary to set xmx here since we got this
`org.gradle.jvmargs=-Xmx768m` in file gradle.properties? If we are going to use
768m as the xmx, we should just remove the 64m setting to avoid confusion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]