jackye1995 edited a comment on pull request #3448: URL: https://github.com/apache/iceberg/pull/3448#issuecomment-961584838
@kbendick thanks for the comment, I somehow ignored this PR, my bad. I believe we have merged the correct fix you made in #3468, so we can close this one @tomtongue For anyone with the same line of thought, there were a few attempts to add this already in the past. However, as you see the input and out format and serdes you set here are really just "hacks" to make Hive happy, they are not actually the correct information in the table, adding that would just mislead users. By not setting these values, we are trying to ask people to follow the right way to use an Iceberg catalog in the Hive engine, and Glue here is just an implementation of that Iceberg catalog interface similar to any other implementations out there. I don't want to create this backdoor for only GlueCatalog simply based on the argument that Glue is "Hive compatible", as in fact it is not Hive 2 and 3 compatible especially in the write path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
