kbendick commented on pull request #3448: URL: https://github.com/apache/iceberg/pull/3448#issuecomment-961608528
> Thanks for your suggestion and comment for this, @kbendick @jackye1995 . Actually I tried using hive engine enabled option, however it didn't work well, failed with ` org.apache.hadoop.hive.ql.metadata.HiveException: Unable to fetch table iceberg_1636005278. StorageDescriptor#InputFormat cannot be null for table: iceberg_1636005278 (Service: null; Status Code: 0; Error Code: null; Request ID: null; Proxy: null)`. Also the #3468 still doesn't fix this. > > It's because that renaming a Glue Data Catalog table with SparkSQL itself (not through Iceberg renaming) needs the input/outformat and serdelib in the StorageDescriptor part at least. > > The Glue Data Catalog doesn't support renaming a table. So if we try renaming the table whose input/output format and serdelib part is filled in, `java.lang.UnsupportedOperationException: Table rename is not supported` error will be thrown. I think this message be expected for users. > > I totally agree your comment on this change, the problem is not critical and the change might not be flexible for the future. However the error message is also misleading and I will think about a better solution. > > Closing this. Thanks for your kind discussion. Thank you for your contribution @tomtongue, even if ultimately it wasn’t the right direction as @jackye1995 mentioned. I agree with Jack’s assessment that we should stick to using the Iceberg catalogs as they’re intended and avoid any hacks that might confuse other users. While the error message for Glue users would arguably be a bit more clear (though still an error), people looking through the Iceberg code and people looking to contribute to Iceberg could get very confused about adding in this unnecessary SerDe information. As Jack mentioned, it might also confuse Glue users into thinking that it’s fully Hive compatible (which I can’t speak to personally but can easily know that we should defer to Jack’s expertise in this area). Thanks for taking the time to submit a patch and for your overall interest in Iceberg. While this patch wasn’t right for the project, we’d absolutely love to have more contributions from you in the future! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
