kbendick commented on a change in pull request #3770:
URL: https://github.com/apache/iceberg/pull/3770#discussion_r773508843



##########
File path: rest_docs/rest-catalog-open-api.yaml
##########
@@ -0,0 +1,849 @@
+#

Review comment:
       I would personally choose to leave 5xx off of the document. I consider a 
potential 500 as an implicit response for any HTTP request, as it's possible 
the request returns 5xx before even reaching the application server.
   
   I personally try to avoid explicitly returning 5xx as part of the normal 
flow of code, but implicitly all manner of 5xx should be expected. I'm just not 
sure if it's worth spelling out for every route.
   
   If others think we should include them, I'd be ok with that.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to