kbendick commented on a change in pull request #3770:
URL: https://github.com/apache/iceberg/pull/3770#discussion_r777305107
##########
File path: rest_docs/rest-catalog-open-api.yaml
##########
@@ -0,0 +1,849 @@
+#
Review comment:
I see here, in the Confluent Kafka REST open api doc, that they have a
`5xx` response. This makes sense to me given that 5xx is often thrown by the
server and usually is used that way:
https://github.com/confluentinc/kafka-rest/blob/master/api/v3/openapi.yaml#L77-L78
We can iterate on that if we need specific 5xx errors, but I think that's
sufficient for now.
As a side note, I am likely going to reorganize some of this document in the
style they use, but in a follow up PR. We can discuss then which parts we would
like to organize around and which we wouldn't. For now though, I'd like to keep
it as close to what we agreed on just to be able to move forward. There will be
more PRs opened against this for sure 👍
But I've added 5xx. Will be adding 400 as well. Thank you both for the
review!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
