pvary commented on a change in pull request #4218:
URL: https://github.com/apache/iceberg/pull/4218#discussion_r817477319



##########
File path: data/benchmark/.gitkeep
##########
@@ -0,0 +1,18 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one

Review comment:
       I copied what we have here:
   
https://github.com/apache/iceberg/blob/master/spark/v3.2/spark/benchmark/.gitkeep
   
   The file is to have a directory when checking out the files, but I am not 
really sure why we do this.
   
   We might want to delete this from both places - I was hoping someone with 
more knowledge about the current test could comment on this.
   
   Thanks for the review!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to