pvary commented on a change in pull request #4218:
URL: https://github.com/apache/iceberg/pull/4218#discussion_r817619563
##########
File path: data/benchmark/.gitkeep
##########
@@ -0,0 +1,18 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Review comment:
I am not sure why we want to create and keep this directory 😢
I have seen that we run the tests like this:
```
./gradlew cleanTest :iceberg-data:jmh
-PjmhIncludeRegex=GenericOrcReaderBenchmark
-PjmhOutputPath=benchmark/benchmark-result.txt.orc
```
But I am not sure that using the directory is needed for some CI, or other
tool, or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
