openinx commented on a change in pull request #4218:
URL: https://github.com/apache/iceberg/pull/4218#discussion_r818257615
##########
File path: data/benchmark/.gitkeep
##########
@@ -0,0 +1,18 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Review comment:
I'm pretty sure we don't need to add this `benchmark` and
`benchmark/.gitkeep` to git now. I just removed this directory and run the jmh
command from @pvary , everything is okay and in fact it will just generate the
new benchmark directory for the testing report.
@pvary I think we will need to add this `data/benchmark` to the .gitignore
file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
