ajantha-bhat commented on a change in pull request #4379:
URL: https://github.com/apache/iceberg/pull/4379#discussion_r833444028
##########
File path: docs/spark/spark-procedures.md
##########
@@ -198,7 +198,7 @@ the `expire_snapshots` procedure will never remove files
which are still require
| Argument Name | Required? | Type | Description |
|---------------|-----------|------|-------------|
| `table` | ✔️ | string | Name of the table to update |
-| `older_than` | ️ | timestamp | Timestamp before which snapshots will be
removed (Default: 5 days ago) |
+| `older_than` | ️ | timestamp | Timestamp before which snapshots will be
removed (Default: 5 days ago). Considered upto millisecond precision. |
Review comment:
I think people assume it is microsecond precision as spark is
microsecond precision, but code we are losing the precision (lossy conversion
to milli), so I think better to clarify in the docs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
